This code is based on code found on https://gist.github.com/JayKickliter
for the FindJulia.cmake. the rest was just adding the necessary
bits for correctnly finding and linking against the libjulia if julia
is found on the system, and do nothing otherwise.
Details
Details
- Reviewers
tcanabrava
compiles fine now.
Diff Detail
Diff Detail
- Repository
- R55 Cantor
- Branch
- fixJulia
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Thanks @tcanabrava but @ivanlakhtanov is working in this bug with this same approach in D2575.
Please, can you close this revision? I can not to do it. :\
| cmake/FindJulia.cmake | ||
|---|---|---|
| 36 | This is not always correct as output contains newlines. You need to strip returned value. | |
| 40 | You aren't checking that /usr/include/julia even exists. Julia executable returns it always, even when no folder present. Installation of Julia without devel package may be accepted by this script. | |
| 45 | This is now outdated. Latest julia has this function: Libdl.dlpath and there is no dlpath in Sys | |
| src/backends/julia/juliaserver/CMakeLists.txt | ||
| 10 | Thanks, I've missed it creating my patch. | |
Comment Actions
Thanks @tcanabrava, the revision D2575 was merged, now this revision is no more necessary.