Differential D25769

Rename KDE Applications to the release service
ClosedPublic
Actions

Authored by • jriddell on Dec 5 2019, 5:22 PM.

Details

Reviewers
aacid
Group Reviewers
KDE Games
Commits
R384:fbaeccac09b7: Rename KDE Applications to the release service
Summary

Rename variables in cmake

Test Plan

build it

Diff Detail

Repository
R384 Bomber
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19524
Build 19542: arc lint + arc unit
• jriddell created this revision.Dec 5 2019, 5:22 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptDec 5 2019, 5:22 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
• jriddell requested review of this revision.Dec 5 2019, 5:22 PM
aacid added a comment.Dec 5 2019, 7:55 PM

don't do reviews for this, you will die, just make sure the scripts are up to date so they update the proper variables

The patch is wrong BTW ;)

CMakeLists.txt
5

Nope, wrong variables used

This revision was not accepted when it landed; it landed in state Needs Review.Dec 10 2019, 4:43 PM
Closed by commit R384:fbaeccac09b7: Rename KDE Applications to the release service (authored by • jriddell). · Explain Why
This revision was automatically updated to reflect the committed changes.
• jriddell added a comment.Dec 11 2019, 2:45 PM

I've now committed this for all the stuff in the release service, I don't see any problems on build.kde.org CI but do watch out for any

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (10 lines)

Diff 70971

View Options

CMakeLists.txt

Loading...