Rename KDE Applications to the release service
ClosedPublic
Actions

Authored by jriddell on Dec 5 2019, 5:22 PM.

Details

Reviewers

aacid

Group Reviewers

KDE Games

Commits

Summary

Rename variables in cmake

Test Plan

build it

Repository

R384 Bomber

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript

jriddell requested review of this revision.Dec 5 2019, 5:22 PM

don't do reviews for this, you will die, just make sure the scripts are up to date so they update the proper variables

The patch is wrong BTW ;)

CMakeLists.txt
5	Nope, wrong variables used

This revision was not accepted when it landed; it landed in state Needs Review.Dec 10 2019, 4:43 PM

This revision was automatically updated to reflect the committed changes.

I've now committed this for all the stuff in the release service, I don't see any problems on build.kde.org CI but do watch out for any

			Path	Packages
M			CMakeLists.txt (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	70971	8d64daa		Dec 5 2019, 5:22 PM	★	★
Diff 2	71208	8d64daa	R384:fbaeccac09b732a4de414bf5f25570936ac62d11	Dec 10 2019, 1:49 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
d37961ff9410	c64dd21ec8e8	8d64daa07de1	Jonathan Riddell	Rename KDE Applications to the release service (Show More…)	Dec 5 2019, 5:22 PM