Details
- Reviewers
romangg - Group Reviewers
KWin - Commits
- R108:f6128ec8757b: Provide a fake approach to tablet event propagation
Diff Detail
- Repository
- R108 KWin
- Branch
- input3
- Lint
Lint Skipped Excuse: x - Unit
No Unit Test Coverage - Build Status
Buildable 19519 Build 19537: arc lint + arc unit
pointer_input.h | ||
---|---|---|
60 | Wouldn't it be better to have an utility function that one can use to get a button code for the given Qt::MouseButton? API-wise, I think we need something like this Qt::MouseButton buttonToQtMouseButton(uint32_t button); uint32_t qtToButtonMouseButton(Qt::MouseButton button); |
pointer_input.h | ||
---|---|---|
60 | Why add a function nobody needs? The function is already present, only not exposed to the header. |
pointer_input.h | ||
---|---|---|
60 | I'm asking you only to replace buttonCodeToQt with the utility function. // pointer_input.h uint32_t qtToButtonMouseButton(Qt::MouseButton button); // pointer_input.cpp uint32_t qtToButtonMouseButton(Qt::MouseButton button) { return s_buttonToQtMouseButton.key(button); } |
pointer_input.h | ||
---|---|---|
60 | Yea, definitely makes sense. Also that the function for the other direction is not implemented. |
pointer_input.h | ||
---|---|---|
60 | I meant "not exposed" |
pointer_input.h | ||
---|---|---|
60 | I agree it's better as a function, I was asked to return a hash in this comment here Maybe I misunderstood, @romangg can you confirm? |
pointer_input.h | ||
---|---|---|
60 | Yea, this was a misunderstanding. I meant there the internal representation should be changed to being a hash instead of a switch-statement in a separate patch (as you did in D25763), but I didn't mean that the getter should return the full hash, only that the getter should be exposed as well in a separate patch. |
pointer_input.cpp | ||
---|---|---|
95 | Forgot to remove? |
Let's go with this filter approach for now. Later we can look into if and how we want to align it with our current touch to pointer fallback in KWayland. I will create a task for that.