Differential D25754

Refactor KHistoryComboBox::insertItems
ClosedPublic
Actions

Authored by nicolasfella on Dec 4 2019, 11:21 PM.

Details

Reviewers
apol
Group Reviewers
Frameworks
Commits
R284:ecb651bb2ee6: Refactor KHistoryComboBox::insertItems
Summary

Use range-based for instead of iterators
Apply return-early idiom

Test Plan

Still get entries in FolderDialog

Diff Detail

Repository
R284 KCompletion
Branch
refa
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19502
Build 19520: arc lint + arc unit
nicolasfella created this revision.Dec 4 2019, 11:21 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 4 2019, 11:21 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Dec 4 2019, 11:21 PM
apol accepted this revision.Dec 5 2019, 12:17 AM
This revision is now accepted and ready to land.Dec 5 2019, 12:17 AM
Closed by commit R284:ecb651bb2ee6: Refactor KHistoryComboBox::insertItems (authored by nicolasfella). · Explain WhyDec 7 2019, 2:41 PM
This revision was automatically updated to reflect the committed changes.
mlaurent added a subscriber: mlaurent.Dec 7 2019, 3:25 PM
mlaurent added inline comments.
src/khistorycombobox.cpp
435

Missing & here no ?

Revision Contents
Changeset List

PathPackages
Msrc/khistorycombobox.cpp (23 lines)

Diff 70926

View Options

src/khistorycombobox.cpp

Loading...