Refactor KHistoryComboBox::insertItems
ClosedPublic
Actions

Authored by nicolasfella on Dec 4 2019, 11:21 PM.

Details

Reviewers

apol

Group Reviewers

Frameworks

Commits

R284:ecb651bb2ee6: Refactor KHistoryComboBox::insertItems

Summary

Use range-based for instead of iterators
Apply return-early idiom

Test Plan

Still get entries in FolderDialog

Repository

R284 KCompletion

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

nicolasfella requested review of this revision.Dec 4 2019, 11:21 PM

This revision is now accepted and ready to land.Dec 5 2019, 12:17 AM

This revision was automatically updated to reflect the committed changes.

mlaurent added inline comments.

src/khistorycombobox.cpp
435	Missing & here no ?

			Path	Packages
M			src/khistorycombobox.cpp (23 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	70926	5647660		Dec 4 2019, 11:21 PM	★	★
Diff 2	71054	5647660	R284:ecb651bb2ee6c6d227e65aef6ef73438291e081c	Dec 7 2019, 2:41 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
a0cf9fdb1c2d	1b009fdf79bd	56476607c32f	Nicolas Fella	Refactor KHistoryComboBox::insertItems (Show More…)	Dec 4 2019, 11:21 PM