EBN extra-cmake-modules transport cleanup
ClosedPublic
Actions

Authored by jhayes on Dec 4 2019, 10:21 PM.

Details

Reviewers

apol
krop

Commits

R240:f082ed20e6a8: EBN extra-cmake-modules transport cleanup

Summary

Change transport protocol from http to https

Diff Detail

Repository

R240 Extra CMake Modules

Branch

ebn-transport-cleanup (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19525
Build 19543: arc lint + arc unit

jhayes created this revision.Dec 4 2019, 10:21 PM

Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptDec 4 2019, 10:21 PM

Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript

jhayes requested review of this revision.Dec 4 2019, 10:21 PM

Harbormaster completed remote builds in B19501: Diff 70925.Dec 4 2019, 10:21 PM

apol accepted this revision.Dec 5 2019, 12:15 AM

This revision is now accepted and ready to land.Dec 5 2019, 12:15 AM

krop requested changes to this revision.Dec 5 2019, 9:27 AM

krop added a subscriber: krop.

krop added inline comments.

docs/CMakeLists.txt
35 ↗	(On Diff #70925)	Please check
find-modules/FindCanberra.cmake
98 ↗	(On Diff #70925)	redirects to http://http://0pointer.net/ which is probably wrong.
kde-modules/KDEInstallDirs.cmake
250 ↗	(On Diff #70925)	expired certificate, I recommend keeping http
kde-modules/clang-format.cmake
29	This address is now redirected to https://webkit.org/code-style-guidelines/

This revision now requires changes to proceed.Dec 5 2019, 9:27 AM

krop added inline comments.Dec 5 2019, 9:28 AM

find-modules/FindCanberra.cmake
98 ↗	(On Diff #70925)	redirects to http://0pointer.net/ which is probably wrong.

Corrections made per review comments.

Reverted some non-working URL's back to http and updated one URL to the correct address

Harbormaster completed remote builds in B19515: Diff 70958.Dec 5 2019, 2:50 PM

The sphinx doc URL is https://www.sphinx-doc.org (it just doesn't work without www)

Corrected URL as review comments

Corrected url to http://www.sphinx-doc.org

Harbormaster completed remote builds in B19525: Diff 70973.Dec 5 2019, 6:15 PM

krop accepted this revision.Dec 5 2019, 9:12 PM

This revision is now accepted and ready to land.Dec 5 2019, 9:12 PM

Closed by commit R240:f082ed20e6a8: EBN extra-cmake-modules transport cleanup (authored by jhayes, committed by krop). · Explain WhyDec 5 2019, 9:14 PM

This revision was automatically updated to reflect the committed changes.

please send me a list of urls that don't have https: and I'll add them to the whitelist

In D25753#572894, @winterz wrote:

please send me a list of urls that don't have https: and I'll add them to the whitelist

The x86-64.org domain is dead. I'm not sure about what could be used instead.

The two links I know of are:
http://0pointer.de/lennart/projects/libcanberra (works as is in file but
wont work as https)
http://www.x86-64.org/documentation/abi.pdf (http://www.x86-64.org is dead)

Revision Contents
Changeset List

			Path	Packages
M			cmake/FindSphinx.cmake (2 lines)
M			find-modules/FindLibExiv2.cmake (2 lines)
M			find-modules/FindOpenEXR.cmake (2 lines)
M			kde-modules/clang-format.cmake (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	70925	23d868a		Dec 4 2019, 10:20 PM	★	★
Diff 2	70958	23d868a	- Corrections made per review comments.	Dec 5 2019, 2:50 PM	★	★
Diff 3	70973	23d868a	- Corrected URL as review comments	Dec 5 2019, 6:15 PM	★	★
Diff 4	70986	9f44119	R240:f082ed20e6a8e5c4808922e52fefa630f9dd4959	Dec 5 2019, 9:14 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
46fe27ac884f	ff867c340f93	d2d9f20156e0	John Hayes	Corrected URL as review comments	Dec 5 2019, 6:13 PM
d2d9f20156e0	887c13b3d388	792fcabc909e	John Hayes	Corrections made per review comments.	Dec 5 2019, 2:45 PM
792fcabc909e	89ec3cc97265	23d868a07712	John Hayes	EBN extra-cmake-modules transport cleanup (Show More…)	Dec 4 2019, 10:18 PM