Properties need to start with lower-case letters, otherwise QML won't
understand them.
Details
Details
- Reviewers
tcanabrava ervin - Group Reviewers
Frameworks - Commits
- R296:12b3c947a8a4: Adapt to change in KConfigCompiler
Diff Detail
Diff Detail
- Repository
- R296 KDeclarative
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
My gut feeling would be to keep the item and the property names in sync unlike now... but this is a good fix as well indeed.
Comment Actions
I'll land this for now because the alternative is to have this not working.
Maybe it would make sense to include a KConfigSkeletonItem::propertyName property? Or even a KConfigSkeletonItem::notifySignal(KConfigSkeleton*)?
Then here we could just consume the information KConfig provides.
I would prefer not to change ::name(), because if a setting is "SomethingElse", we could end up using as "somethingElse" somewhere, and that would be ambiguous.
@ervin what do you think?
Comment Actions
notifySignal would definitely make sense on the signalling items indeed. It's kind of the information we're trying to guess here. And then propertyName on base item type of course.