support userBackgroundhints in the scripting ui
ClosedPublic
Actions

Authored by mart on Dec 4 2019, 3:29 PM.

Details

Reviewers

None

Group Reviewers

Plasma

Commits

Summary

bind userBackgroundHints to the desktopscript interface

Test Plan

from the scripting console is possible to correctly change applets background and
it gets immediately applied

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart requested review of this revision.Dec 4 2019, 3:29 PM

apol added inline comments.

shell/scripting/widget.h
71	const& or should it be Plasma::Types::BackgroundHints?

shell/scripting/widget.h
71	everthing else presents strings to the engine. i don't know if it's possible making enums work correctly with qjsengine (that is without qml)

This revision was not accepted when it landed; it landed in state Needs Review.Dec 5 2019, 10:00 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			shell/scripting/widget.h (4 lines)
M			shell/scripting/widget.cpp (17 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	70908	c70fb9d		Dec 4 2019, 3:29 PM	★	★
Diff 2	70942	a137113	R120:786951fec803a68447d29e928742aa915aee1a05	Dec 5 2019, 10:00 AM	★	★