Add item spacing to size hint
ClosedPublic

Authored by broulik on Dec 4 2019, 1:51 PM.

Details

Summary

This is what Adwaita Qt does [1] and it fixes the popup text being elided in Krita's filter popup with D25739

[1] https://github.com/FedoraQt/adwaita-qt/blob/master/style/adwaitastyle.cpp#L2856

Test Plan

5.17?

  • Other comboboxes look unchanged because iirc it only uses that size hint for the popup contents in SH_ComboBoxPopup mode, not in the default case we have in Breeze usually

Before


After

Diff Detail

Repository
R31 Breeze
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Dec 4 2019, 1:51 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 4 2019, 1:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Dec 4 2019, 1:51 PM
ndavis accepted this revision.Dec 4 2019, 2:25 PM
This revision is now accepted and ready to land.Dec 4 2019, 2:25 PM
ngraham added a subscriber: ngraham.Dec 4 2019, 5:12 PM

5.17 I'd say.

This revision was automatically updated to reflect the committed changes.