[KisColorFilterCombo] Force ComboBox popup
ClosedPublic
Actions

Authored by broulik on Dec 4 2019, 1:48 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

Only in this mode will Qt respect the contents of the ComboBox popup. This is what Fusion uses.

BUG: 406595

Test Plan

Filter combo is usable in Adwaita-Qt and Windows 95 style now. There's a minor size bug in Breeze I'll address separately there, see D25740

Repository

R37 Krita

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a project: Krita. · View Herald TranscriptDec 4 2019, 1:48 PM

broulik requested review of this revision.Dec 4 2019, 1:48 PM

broulik edited the test plan for this revision. (Show Details)

broulik edited the test plan for this revision. (Show Details)Dec 4 2019, 1:53 PM

libs/ui/widgets/kis_color_filter_combo.cpp
174	This looks kind of weird? Returning a true for an int?

libs/ui/widgets/kis_color_filter_combo.cpp
174	That's what Qt and everyone else does. There's also style hints for "wheel scroll lines" and flags it may return.

Okay :-)

This revision is now accepted and ready to land.Dec 4 2019, 2:22 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			libs/ui/widgets/kis_color_filter_combo.cpp (23 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	70901			Dec 4 2019, 1:47 PM	★	★
Diff 2	70936	2dc2ed5	R37:818c841b0b20fc6d56e6365fcd57a620a6d98303	Dec 5 2019, 8:01 AM	★	★