Remove deprecated method
ClosedPublic

Authored by mlaurent on Dec 4 2019, 12:32 PM.

Details

Summary

Remove some deprecated method

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mlaurent created this revision.Dec 4 2019, 12:32 PM
Restricted Application added a project: KWin. · View Herald TranscriptDec 4 2019, 12:32 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
mlaurent requested review of this revision.Dec 4 2019, 12:32 PM
zzag added a subscriber: zzag.EditedDec 4 2019, 1:17 PM

This patch contains a few unrelated changes. Could you please put them in other patches? Also, this patch doesn't remove any methods. ;-)

The .toStrongRef() is related.

QWeakPointer::data() is deprecated

"This patch contains a few unrelated changes" which ones ?
"Qt::Orientations newLayout = nullptr;" is deprecated so we can't compile against qt5.15
"client().data()" is deprecated so we need to use .toStrongRef().data();
qmlRegisterType is deprecated.

I can't see unrelated changes here.

zzag added a comment.Dec 4 2019, 3:18 PM

Heh, it seems you see this revision as one monolithic "remove usages of some deprecated functions and methods" and I see it as "use QWeakPointer::toStrongRef() instead of deprecated QWeakPointer::data(), use qmlRegisterAnonymousType() instead of deprecated qmlRegisterType(), fix initialization of QFlags<T>."

I guess this patch can go in, but I think it'll be better to have a patch for each individual change.

zzag accepted this revision.Dec 23 2019, 11:58 AM

Let's get this change in.

This revision is now accepted and ready to land.Dec 23 2019, 11:58 AM
This revision was automatically updated to reflect the committed changes.