Differential D25733

[scenes/xrender] Correctly render client-side decorated clients
ClosedPublic
Actions

Authored by zzag on Dec 4 2019, 12:08 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:8ab727766a51: [scenes/xrender] Correctly render client-side decorated clients
Summary

The buffer shape is in buffer-local coordinates and must be mapped to
window coordinates. After that, we are free to map it to the global screen
coordinates.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Dec 4 2019, 12:08 PM
Restricted Application added a project: KWin. · View Herald TranscriptDec 4 2019, 12:08 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Dec 4 2019, 12:08 PM
zzag updated this revision to Diff 70888.Dec 4 2019, 12:09 PM

Update comment.

zzag updated this revision to Diff 70959.Dec 5 2019, 2:50 PM

Map only the buffer shape, the decoration rect and the shadow region are in window coordinates

zzag edited the summary of this revision. (Show Details)Dec 5 2019, 2:51 PM
davidedmundson accepted this revision.Dec 12 2019, 12:00 PM
This revision is now accepted and ready to land.Dec 12 2019, 12:00 PM
Closed by commit R108:8ab727766a51: [scenes/xrender] Correctly render client-side decorated clients (authored by zzag). · Explain WhyDec 12 2019, 12:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 71356

View Options

plugins/scenes/xrender/scene_xrender.h

Loading...
View Options

plugins/scenes/xrender/scene_xrender.cpp

Loading...