Make it compile against qt5.14 without deprecated method
ClosedPublic

Authored by mlaurent on Tue, Dec 3, 7:01 AM.

Details

Summary

Compile against 5.14 without deprecated method

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mlaurent created this revision.Tue, Dec 3, 7:01 AM
Restricted Application added a project: Plasma. · View Herald TranscriptTue, Dec 3, 7:01 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mlaurent requested review of this revision.Tue, Dec 3, 7:01 AM
apol added inline comments.Tue, Dec 3, 12:40 PM
plugin/kquickstyleitem.cpp
109

Maybe use org.kde.qqc2desktopstyle.private which we are already using?

Also shouldn't we be registering the types and the plugin class rather than on every instance of the type?

yep it seems more logical

mlaurent updated this revision to Diff 70875.Wed, Dec 4, 6:36 AM

Fix comment

mlaurent updated this revision to Diff 70876.Wed, Dec 4, 6:40 AM

Forgot to commit it

apol accepted this revision.Wed, Dec 4, 12:17 PM
This revision is now accepted and ready to land.Wed, Dec 4, 12:17 PM
This revision was automatically updated to reflect the committed changes.