Differential D25705

Deprecate KIO::pixmapForUrl
AbandonedPublic
Actions

Authored by nicolasfella on Dec 3 2019, 12:09 AM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Summary

Can easily be done otherwise.

Diff Detail

Repository
R241 KIO
Branch
arcpatch-D25705_1
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25276
Build 25294: arc lint + arc unit
nicolasfella created this revision.Dec 3 2019, 12:09 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 3 2019, 12:09 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Dec 3 2019, 12:09 AM
apol added a subscriber: apol.Dec 3 2019, 12:38 PM

What do you mean by Can easily be done otherwise.?

kossebau added a subscriber: kossebau.Dec 3 2019, 3:02 PM
kossebau added inline comments.
src/widgets/pixmaploader.h
51

This line should be before the API dox comment.

nicolasfella added a comment.Dec 30 2019, 7:21 PM
In D25705#571458, @apol wrote:

What do you mean by Can easily be done otherwise.?

You can get an icon name for the icon with KIO::iconNameForUrl and then use QIcon API if you really need a pixmap

nicolasfella updated this revision to Diff 80199.Apr 15 2020, 1:47 PM
  • Fix update
nicolasfella planned changes to this revision.Apr 15 2020, 1:48 PM

Seems like I missed some usages

kossebau added inline comments.Apr 15 2020, 1:55 PM
src/widgets/pixmaploader.h
37

@deprecated should go after @return here, cmp. https://community.kde.org/Frameworks/Frameworks_Documentation_Policy#Document_Public_and_Protected_Members

Revision Contents
Changeset List

Diff 80199

View Options

src/widgets/CMakeLists.txt

Loading...
View Options

src/widgets/pixmaploader.h

Loading...
View Options

src/widgets/pixmaploader.cpp

Loading...