Sync scrollbar behavior with GTK applications
ClosedPublic
Actions

Authored by gikari on Dec 2 2019, 11:26 PM.

Details

Reviewers

cblack
ngraham
apol

Group Reviewers

VDG

Maniphest Tasks

T10611: Set options for GTK apps in the respective KCMs

Commits

R99:68787ff9d3d4: Sync scrollbar behavior with GTK applications

Summary

Previously GTK applications respected their own setting on what should happen when an user clicks below or above scrollbar slider. Now it is in sync with Plasma and Qt applications settings.

Problems:

I'm failed to found DConf GTK setting, that is responsible for scrollbar behavior. Maybe someone could help.
Setting apply on the go do not work with GTK2 apps, therefore they need to be reloaded to respect the new setting.

Test Plan

Update plasma-desktop and frameworkintegration
Launch workspace behavior KCM and change scrollbar setting Clicking on scrollbar track
GTK3 apps should now respect the setting

Diff Detail

Repository

R99 KDE Gtk Configuration Tool

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

gikari created this revision.Dec 2 2019, 11:26 PM

Restricted Application added a project: Plasma. · View Herald TranscriptDec 2 2019, 11:26 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

gikari requested review of this revision.Dec 2 2019, 11:26 PM

Harbormaster completed remote builds in B19420: Diff 70796.Dec 2 2019, 11:26 PM

gikari added a reviewer: VDG.Dec 2 2019, 11:27 PM

gikari mentioned this in T10611: Set options for GTK apps in the respective KCMs.

gikari added a task: T10611: Set options for GTK apps in the respective KCMs.Dec 2 2019, 11:31 PM

Nice, works great. Wanna remove the option in the KCM in this patch too?

gikari added a dependent revision: D25711: Remove scrollbar behavior option in GTK KCM.Dec 3 2019, 8:06 AM

In D25703#571286, @ngraham wrote:

Nice, works great. Wanna remove the option in the KCM in this patch too?

Oops. I did it in separate one D25711. Should I undo?

That's fine, no worries.

@cblack and/or Plasma people, all good here?

This revision is now accepted and ready to land.Dec 3 2019, 7:11 PM

GB_2 mentioned this in D25360: Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals setting.Dec 8 2019, 12:13 PM

Closed by commit R99:68787ff9d3d4: Sync scrollbar behavior with GTK applications (authored by gikari, committed by ngraham). · Explain WhyDec 10 2019, 10:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kded/configeditor.cpp (1 line)
M			kded/configvalueprovider.h (1 line)
M			kded/configvalueprovider.cpp (12 lines)
M			kded/gtkconfig.h (1 line)
M			kded/gtkconfig.cpp (11 lines)