Differential D25702

Deprecate KUrlPixmapProvider
ClosedPublic
Actions

Authored by nicolasfella on Dec 2 2019, 11:23 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R241:00e8034f0e9a: Deprecate KUrlPixmapProvider
Summary

See T12310 for context

Test Plan

builds

Diff Detail

Repository
R241 KIO
Branch
pmpr
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19419
Build 19437: arc lint + arc unit
nicolasfella created this revision.Dec 2 2019, 11:23 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 2 2019, 11:23 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Dec 2 2019, 11:23 PM
nicolasfella updated this revision to Diff 72414.Dec 30 2019, 7:40 PM
  • Update version
dfaure accepted this revision.Jan 1 2020, 10:25 AM

Thanks!

This revision is now accepted and ready to land.Jan 1 2020, 10:25 AM
dfaure requested changes to this revision.Jan 1 2020, 10:25 AM
dfaure added inline comments.
src/widgets/kurlpixmapprovider.cpp
26

Ah, no, s/ENABLE_/BUILD_/ in cpp files

This revision now requires changes to proceed.Jan 1 2020, 10:25 AM
nicolasfella marked an inline comment as done.Jan 1 2020, 2:55 PM
dfaure accepted this revision.Jan 1 2020, 6:00 PM
This revision is now accepted and ready to land.Jan 1 2020, 6:00 PM
Closed by commit R241:00e8034f0e9a: Deprecate KUrlPixmapProvider (authored by nicolasfella). · Explain WhyJan 1 2020, 6:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 70795

View Options

src/widgets/CMakeLists.txt

Loading...
View Options

src/widgets/kurlpixmapprovider.h

Loading...
View Options

src/widgets/kurlpixmapprovider.cpp

Loading...