Differential D25697

Port away from KIconLoader::SizeSmallMedium
Needs ReviewPublic
Actions

Authored by nicolasfella on Dec 2 2019, 9:31 PM.

Details

Reviewers
None
Group Reviewers
Frameworks
Maniphest Tasks
T11637: KIconThemes Cleanups
Summary

There is no direct equivalent of SizeSmallMedium (22) in QStyle. There is either Small (16) or large (32)

Test Plan

builds

Diff Detail

Repository
R241 KIO
Branch
sm2
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19411
Build 19429: arc lint + arc unit
nicolasfella created this revision.Dec 2 2019, 9:31 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 2 2019, 9:31 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Dec 2 2019, 9:31 PM
cfeck added a subscriber: cfeck.Dec 2 2019, 9:53 PM

Traditionally, 22 was used for toolbar icons. You could replace 22 with QStyle::PM_ToolBarIconSize, but it really depends on where you want the icons to appear. Generally, QStyle::PM_SmallIconSize is for icons that are placed next to a single line of text, unless there is a more specifc PixelMetric enum, e.g. QStyle::PM_ButtonIconSize.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/ksslinfodialog.cpp (9 lines)

Diff 70783

View Options

src/widgets/ksslinfodialog.cpp

Loading...