Port away from deprecated DesktopIcon
ClosedPublic

Authored by nicolasfella on Mon, Dec 2, 8:32 PM.

Details

Summary

Use QIcon::fromTheme

Test Plan

Still get the stopwatch icon as thumbnail when thumbnail is loaded

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Mon, Dec 2, 8:32 PM
Restricted Application added a project: Gwenview. · View Herald TranscriptMon, Dec 2, 8:32 PM
nicolasfella requested review of this revision.Mon, Dec 2, 8:32 PM
vkrause accepted this revision.Tue, Dec 3, 8:02 AM
vkrause added a subscriber: vkrause.
vkrause added inline comments.
lib/thumbnailview/thumbnailview.cpp
390

btw, QIcon::pixmap exists in a single argument variant as well, so you don't have to repeat the size in the common case of a square icon :)

This revision is now accepted and ready to land.Tue, Dec 3, 8:02 AM
  • Use single arg fucntion
This revision was automatically updated to reflect the committed changes.
nicolasfella marked an inline comment as done.Tue, Dec 3, 7:24 PM