KDirOperator: Use a fixed line height for scroll speed
ClosedPublic

Authored by ahiemstra on Dec 2 2019, 2:07 PM.

Details

Summary

This patch intends to do mostly the same as D19190, but for KDirOperator.
This uses the font's line height multiplied by the amount of scroll lines
from QApplication as a scroll speed for views. This makes the scroll speed
not depend on the icon size, which greatly improves scrolling behaviour.
For more details, see the linked review.

Test Plan

Run tests/kfilewidgettest_gui and go to a directory with a lot of items.
Scroll around, then change icon size and see that scrolling speed remains
the same.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahiemstra created this revision.Dec 2 2019, 2:07 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 2 2019, 2:07 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ahiemstra requested review of this revision.Dec 2 2019, 2:07 PM
ahiemstra edited the summary of this revision. (Show Details)Dec 2 2019, 2:08 PM
This revision is now accepted and ready to land.Dec 2 2019, 3:03 PM
elvisangelaccio accepted this revision.Dec 8 2019, 8:46 PM