This also replaces some for-loops with C++11 range based for-loops and switches for simpler if/else control blocks.
Details
Details
- Reviewers
dfaure - Group Reviewers
Frameworks - Commits
- R265:45b6460b0c09: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items
Open colorscheme editor in the Colors KCM to see if any colors or effects look broken.
Diff Detail
Diff Detail
- Repository
- R265 KConfigWidgets
- Branch
- remove-hardcoded-values (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 19375 Build 19393: arc lint + arc unit
Comment Actions
This also replaces some for-loops with C++11 range based for-loops and switches for simpler if/else control blocks.
Seems like these changes are unrelated and should maybe be in a separate commit?
Comment Actions
The intention of the patch is to reduce the number of hardcoded values, so they're related. It wouldn't make sense to switch the hardcoded for-loop ranges for the enum values introduced in the parent patch only to replace them with range based for-loops immediately afterward.
Comment Actions
So many hardcoded numbers! Much better indeed.
| src/kcolorscheme.cpp | ||
|---|---|---|
| 88 | coding style: space after for, and add { ... } around the body, with newlines. | |
| 393 | coding style: if ( with a space (repeats) | |
| 598 | The & seems overkill (and confused me because it looks non-const). | |
Comment Actions
- [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items
- fix code style