Differential D25662

Restore ability to close tab by clicking on close button
ClosedPublic
Actions

Authored by stefanocrocco on Dec 1 2019, 5:42 PM.

Details

Reviewers
dfaure
Commits
R226:919076fa77a2: Restore ability to close tab by clicking on close button
Summary

After making KTabBar and KTabWidget part of Konqueror, clicking on the close
button of a tab didn't make the tab close any longer. This fixes it

Test Plan

Open several tabs in Konqueror, then click on their close button and
check that they close. Check that when only one tab remains, the tab bar is
hidden

Diff Detail

Repository
R226 Konqueror
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
stefanocrocco requested review of this revision.Dec 1 2019, 5:42 PM
stefanocrocco created this revision.
dfaure accepted this revision.Dec 1 2019, 5:59 PM

Thanks for the fix, sorry for not noticing.

This revision is now accepted and ready to land.Dec 1 2019, 5:59 PM
Closed by commit R226:919076fa77a2: Restore ability to close tab by clicking on close button (authored by stefanocrocco). · Explain WhyDec 1 2019, 7:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/konqtabs.h (2 lines)
Msrc/konqtabs.cpp (8 lines)

Diff 70692

View Options

src/konqtabs.h

Loading...
View Options

src/konqtabs.cpp

Loading...