More xfreerdp just bails out if you try to share a non existing folder and you get a :o face without knowing what went wrong
Details
Diff Detail
- Repository
- R436 KRDC
- Branch
- release/19.12
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 19321 Build 19339: arc lint + arc unit
This is a i18n break but since if you have this problem you won't be able to figure out what the problem is unless you debug the source code i'd like for this to go in to 19.12
rdp/rdpview.cpp | ||
---|---|---|
120 | Since this is a new string, please use the correct HIG style:
Also a small nit: "Folder %1 does not exist." -> "The folder %1 does not exist." |
rdp/rdpview.cpp | ||
---|---|---|
119 | Can a directory be not readable? |
rdp/rdpview.cpp | ||
---|---|---|
119 | Hmmm, QDir().exists(shareMediaPath) only checks for the existence of shareMediaPath, it doesn't check that it's a directory. |
I'm going to land this *now* since i want the translatable message to be available for translators so they have a chance to translate it before thursday.
But if you have any other comment i'm happy to fix/address it.
rdp/rdpview.cpp | ||
---|---|---|
119 | true, i totally failed at reading the docu Though it's funny since it actually "works" (i.e. not fails to start that was my original problem) if you give it a file path too, but let's stick with dirs | |
119 | I just double checked and it doesn't matter if the directory is readable or not (at least for my particular verison of xfreerdp) |