Port away from KTextWidgets
ClosedPublic

Authored by nicolasfella on Sat, Nov 30, 2:47 PM.

Details

Summary

It is only used for the bugreport dialog for non-KDE apps. By replacing KTextEdit with QTextEdit we can get rid of a rather large dependency with minimal impact.

The only complication is that the krichtexteditor test uses it. For more context see T12195.

To work around this we only look for KTextWidgets if actually building the tests and only include the relevant test if ktextwidgets is found

Test Plan

builds

Diff Detail

Repository
R263 KXmlGui
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Sat, Nov 30, 2:47 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSat, Nov 30, 2:47 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Sat, Nov 30, 2:47 PM
apol accepted this revision.Sat, Nov 30, 5:33 PM
apol added a subscriber: apol.

LGTM

This revision is now accepted and ready to land.Sat, Nov 30, 5:33 PM
This revision was automatically updated to reflect the committed changes.