[Akonadi] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel
ClosedPublic
Actions

Authored by mlaurent on Nov 29 2019, 10:07 PM.

Details

Reviewers

dvratil
winterz

Commits

R165:de890bed9276: [Akonadi] Port to QSortFilterProxyModel from deprecated…

Summary

KRecursiveFilterProxyModel is dead. Port to QSortFilterProxyModel.

follow instructions in krecursivefilterproxymodel.h:
"If you can depend on Qt >= 5.10, then just use QSortFilterProxyModel::setRecursiveFilteringEnabled(true), and you don't need to use KRecursiveFilterProxyModel."

WARNING: merging this will break mailcommon build. working on a separate patch for mailcommon. perhaps others projects will also fail. don't know yet.

Diff Detail

Repository

R165 Akonadi

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19289
Build 19307: arc lint + arc unit

winterz created this revision.Nov 29 2019, 10:07 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptNov 29 2019, 10:07 PM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

winterz requested review of this revision.Nov 29 2019, 10:07 PM

Harbormaster completed remote builds in B19289: Diff 70591.Nov 29 2019, 10:07 PM

winterz retitled this revision from Port to QSortFilterProxyModel to [Akonadi] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel.Nov 29 2019, 10:08 PM

winterz edited the summary of this revision. (Show Details)

winterz abandoned this revision.Nov 29 2019, 10:22 PM

Hi allen
Why you abandonned all your patch ?

Fix accept row

Harbormaster completed remote builds in B19295: Diff 70600.Nov 30 2019, 11:28 AM

mlaurent commandeered this revision.Nov 30 2019, 11:38 AM

mlaurent edited reviewers, added: winterz; removed: mlaurent.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2019, 11:53 AM

Closed by commit R165:de890bed9276: [Akonadi] Port to QSortFilterProxyModel from deprecated… (authored by mlaurent). · Explain Why

This revision was automatically updated to reflect the committed changes.

In D25621#569644, @mlaurent wrote:

Hi allen
Why you abandonned all your patch ?

I was trying to move to arcanist . then I got all mixed up.
thanks for taking over and fixing my patches.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			autotests/libs/proxymodelstest.cpp (18 lines)
M			src/core/models/entityorderproxymodel.h (6 lines)
M			src/core/models/entityorderproxymodel.cpp (24 lines)
M			src/core/models/entityrightsfiltermodel.h (10 lines)
M			src/core/models/entityrightsfiltermodel.cpp (18 lines)
M			src/core/models/favoritecollectionsmodel.cpp (2 lines)
M			src/core/models/recursivecollectionfilterproxymodel.h (7 lines)
M			src/core/models/recursivecollectionfilterproxymodel.cpp (29 lines)
M			src/core/models/trashfilterproxymodel.h (10 lines)
M			src/core/models/trashfilterproxymodel.cpp (23 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	70591	ad71b25		Nov 29 2019, 10:07 PM	★	★
Diff 2	70600	ad71b25	- Fix accept row	Nov 30 2019, 11:28 AM	★	★
Diff 3	70605	ad71b25	R165:de890bed9276be48582d1198df8d0ed511f0928f	Nov 30 2019, 11:53 AM	★	★