[Akonadi] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel
ClosedPublic

Authored by mlaurent on Fri, Nov 29, 10:07 PM.

Details

Summary

KRecursiveFilterProxyModel is dead. Port to QSortFilterProxyModel.

follow instructions in krecursivefilterproxymodel.h:
"If you can depend on Qt >= 5.10, then just use QSortFilterProxyModel::setRecursiveFilteringEnabled(true), and you don't need to use KRecursiveFilterProxyModel."

WARNING: merging this will break mailcommon build. working on a separate patch for mailcommon. perhaps others projects will also fail. don't know yet.

Diff Detail

Repository
R165 Akonadi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
winterz created this revision.Fri, Nov 29, 10:07 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptFri, Nov 29, 10:07 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
winterz requested review of this revision.Fri, Nov 29, 10:07 PM
winterz retitled this revision from Port to QSortFilterProxyModel to [Akonadi] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel.Fri, Nov 29, 10:08 PM
winterz edited the summary of this revision. (Show Details)
winterz abandoned this revision.Fri, Nov 29, 10:22 PM

Hi allen
Why you abandonned all your patch ?

mlaurent updated this revision to Diff 70600.Sat, Nov 30, 11:28 AM
  • Fix accept row
mlaurent commandeered this revision.Sat, Nov 30, 11:38 AM
mlaurent edited reviewers, added: winterz; removed: mlaurent.
This revision was not accepted when it landed; it landed in state Needs Review.Sat, Nov 30, 11:53 AM
This revision was automatically updated to reflect the committed changes.

Hi allen
Why you abandonned all your patch ?

I was trying to move to arcanist . then I got all mixed up.
thanks for taking over and fixing my patches.