Differential D25620

Register ActionType enum with metaobject system
Needs ReviewPublic
Actions

Authored by jbbgameich on Nov 29 2019, 7:41 PM.

Details

Reviewers
apol

Diff Detail

Repository
R307 KPeople
Branch
actions-meta-enum (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19287
Build 19305: arc lint + arc unit
jbbgameich created this revision.Nov 29 2019, 7:41 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 29 2019, 7:41 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
jbbgameich requested review of this revision.Nov 29 2019, 7:41 PM
apol added a comment.Nov 30 2019, 5:31 PM

the Q_ENUM looks good.

src/declarative/personactionsmodel_p.h
24

Why do we need the include?

jbbgameich added inline comments.Nov 30 2019, 7:42 PM
src/declarative/personactionsmodel_p.h
24

The enum ist defined in that header.

jbbgameich added a comment.EditedDec 3 2019, 5:21 PM

ping

apol added a comment.Dec 4 2019, 1:11 AM

Hi, thanks for your patience.

Can you check if this works?
https://phabricator.kde.org/D25727

Can you share a test case that uses it?

Revision Contents
Changeset List

Diff 70589

View Options

src/declarative/personactionsmodel.cpp

Loading...
View Options

src/declarative/personactionsmodel_p.h

Loading...