Differential D25618

Account for a mnemonic label to go back to ""
ClosedPublic
Actions

Authored by apol on Nov 29 2019, 7:22 PM.

Details

Reviewers
mart
ngraham
Group Reviewers
Kirigami
Commits
R169:e649887194f5: Account for a mnemonic label to go back to ""
Summary

We are discarding the value if there's no weights which meant that when
setting a button to "", the text provided by mnemonicLabel wouldn't update.
This patch changes it so it only skips the weights computation if there's no
text.

Test Plan

Tested with patch that removes the text of some buttons when the
screen is smaller on Discover.

Diff Detail

Repository
R169 Kirigami
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19285
Build 19303: arc lint + arc unit
apol created this revision.Nov 29 2019, 7:22 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptNov 29 2019, 7:22 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Nov 29 2019, 7:22 PM
ngraham accepted this revision as: ngraham.Nov 29 2019, 7:29 PM
This revision is now accepted and ready to land.Nov 29 2019, 7:29 PM
Closed by commit R169:e649887194f5: Account for a mnemonic label to go back to "" (authored by apol). · Explain WhyDec 1 2019, 5:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/mnemonicattached.cpp (72 lines)

Diff 70587

View Options

src/mnemonicattached.cpp

Loading...