Account for a mnemonic label to go back to ""
ClosedPublic

Authored by apol on Fri, Nov 29, 7:22 PM.

Details

Summary

We are discarding the value if there's no weights which meant that when
setting a button to "", the text provided by mnemonicLabel wouldn't update.
This patch changes it so it only skips the weights computation if there's no
text.

Test Plan

Tested with patch that removes the text of some buttons when the
screen is smaller on Discover.

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Fri, Nov 29, 7:22 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptFri, Nov 29, 7:22 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Fri, Nov 29, 7:22 PM
ngraham accepted this revision as: ngraham.Fri, Nov 29, 7:29 PM
This revision is now accepted and ready to land.Fri, Nov 29, 7:29 PM
This revision was automatically updated to reflect the committed changes.