Differential D25612

Simplify load of locale variables
ClosedPublic
Actions

Authored by apol on Nov 29 2019, 11:49 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:26284d73cf94: Simplify load of locale variables
Summary

Load l10n values using kconfig instead of sourcing a generated shell script
from the kcm.

Test Plan

Builds, starts properly

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19274
Build 19292: arc lint + arc unit
apol created this revision.Nov 29 2019, 11:49 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 29 2019, 11:49 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Nov 29 2019, 11:49 AM
davidedmundson added a subscriber: davidedmundson.Nov 29 2019, 11:59 AM

+1

startkde/startplasma.cpp
134–135

This may as well be merged if we're going to open the config next anyway

apol updated this revision to Diff 70567.Nov 29 2019, 1:30 PM

Address david comment, merge all of the LANG things

apol updated this revision to Diff 70568.Nov 29 2019, 1:30 PM

Remember to sync

davidedmundson accepted this revision.Nov 29 2019, 1:47 PM

Lovely.

There's a writeexports.h in p-d to kill too.

This revision is now accepted and ready to land.Nov 29 2019, 1:47 PM
Closed by commit R120:26284d73cf94: Simplify load of locale variables (authored by apol). · Explain WhyNov 29 2019, 3:05 PM
This revision was automatically updated to reflect the committed changes.
apol mentioned this in R119:f5ab71acc03b: Remove generation of plasma-locale-settings.sh.

Revision Contents
Changeset List

Diff 70567

View Options

kcms/translations/translations.cpp

Loading...
View Options

kcms/translations/writeexports.h

Loading...
View Options

startkde/startplasma.cpp

Loading...