Details
Details
- Reviewers
mart davidedmundson crossi bport mlaurent - Group Reviewers
Plasma - Commits
- R119:506d1807e6a4: Port KSMServer's KCM to KConfigXT
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
kcms/ksmserver/kcmsmserver.h | ||
---|---|---|
51 | it seems that ui is never deleted. (I can't see it deleted in destructor.) |
Comment Actions
So much red :D
kcms/ksmserver/kcmsmserver.cpp | ||
---|---|---|
203 | This patch renames this entry "default" to "emptySession" From what I can tell it won't matter for ksmserver itself as that only compares against the other two strings. But if a user had this value set currently then opens the KCM afterwards, which value gets loaded? |
kcms/ksmserver/kcmsmserver.cpp | ||
---|---|---|
203 | Yes, several reasons for that change: default doesn't play well as an enum value, also it wasn't the default at all... since restoring the previous session is. |