Differential D25607

Balance box, fix layout issue
ClosedPublic
Actions

Authored by sambhavkaul on Nov 29 2019, 7:24 AM.

Details

Reviewers
timotheegiet
Group Reviewers
GCompris: Improvements
Maniphest Tasks
T7852: Balance Box, fix ball hidden behind bar buttons
Summary

The layout was overriding with the bar in balance box activity.

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
sambhavkaul created this revision.Nov 29 2019, 7:24 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptNov 29 2019, 7:24 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
sambhavkaul requested review of this revision.Nov 29 2019, 7:24 AM
sambhavkaul added a comment.EditedNov 29 2019, 7:28 AM

So, I changed the length of the layout and moved it to top, now the ball and other items are not overriding with the bar but the thing is how do I now move the bottom space up to bar height as there is empty space now at bottom. I tried 'bottomMargin: bar.height' and 'bottom: bar.top' but they are not doing the job .Any suggestions please ?

timotheegiet accepted this revision.Nov 29 2019, 1:56 PM
timotheegiet added a subscriber: timotheegiet.

Thanks for looking at it,
though I fixed it in master a bit more properly.
You can check the commit for reference here: d3972d63d49000b76d2b1fb5011701ade6dd12cb

This revision is now accepted and ready to land.Nov 29 2019, 1:56 PM
timotheegiet closed this revision.Nov 29 2019, 1:56 PM

Revision Contents
Changeset List

Diff 70540

View Options

src/activities/balancebox/Balancebox.qml

Loading...