[System Tray] Restore old pin button size
ClosedPublic
Actions

Authored by filipf on Nov 28 2019, 7:27 PM.

Details

Reviewers

davidedmundson
broulik

Group Reviewers

Plasma
VDG

Commits

R120:37c1ec10888f: [System Tray] Restore old pin button size

Summary

This size was used before the rewrite (D24720).

Test Plan

Before:

After:

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

filipf requested review of this revision.Nov 28 2019, 7:27 PM

filipf edited the test plan for this revision. (Show Details)Nov 28 2019, 7:29 PM

filipf added reviewers: Plasma, VDG.

use Layout.preferredHeight/Width instead of implicitHeight/Width

I don't like this * 1.25 business, but you are correct that's what the old code did.

This revision is now accepted and ready to land.Nov 29 2019, 12:09 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			applets/systemtray/package/contents/ui/ExpandedRepresentation.qml (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	70525	3600beb		Nov 28 2019, 7:27 PM	★	★
Diff 2	70526	3600beb	use Layout.preferredHeight/Width instead of implicitHeight/Width	Nov 28 2019, 7:49 PM	★	★
Diff 3	70575	26284d7	R120:37c1ec10888f4ff5073a79d41518f962dd03735a	Nov 29 2019, 3:06 PM	★	★