[Akonadi] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel
AbandonedPublic
Actions

Authored by winterz on Nov 28 2019, 4:23 PM.

Details

Reviewers

dvratil
mlaurent

Summary

KRecursiveFilterProxyModel is dead. Port to QSortFilterProxyModel.

follow instructions in krecursivefilterproxymodel.h:
"If you can depend on Qt >= 5.10, then just use QSortFilterProxyModel::setRecursiveFilteringEnabled(true), and you don't need to use KRecursiveFilterProxyModel."

WARNING: merging this will break mailcommon build. working on a separate patch for mailcommon. perhaps others projects will also fail. don't know yet.

Diff Detail

Repository

R165 Akonadi

Lint

Lint Skipped

Unit

Unit Tests Skipped

winterz created this revision.Nov 28 2019, 4:23 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptNov 28 2019, 4:23 PM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

winterz requested review of this revision.Nov 28 2019, 4:23 PM

winterz edited the summary of this revision. (Show Details)

winterz mentioned this in D25596: [mailcommon] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel.Nov 28 2019, 4:34 PM

minor improvements , and fix 1 oopsie.

winterz mentioned this in D25597: [AkonadiConsole] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel.Nov 28 2019, 4:51 PM

mlaurent requested changes to this revision.Nov 28 2019, 4:59 PM

mlaurent added a subscriber: mlaurent.

mlaurent added inline comments.

src/core/models/entityrightsfiltermodel.h
102	Who use this method now ? Please use arc diff we can't see context and it's difficult to review patch. same for other patch thanks

This revision now requires changes to proceed.Nov 28 2019, 4:59 PM

winterz mentioned this in D25598: [kdepim-runtime] Port to QSortFilterProxyModel from deprecated KRecursiveFilterProxyModel.Nov 28 2019, 5:16 PM

See new review using arcanist at https://phabricator.kde.org/D25621

mlaurent mentioned this in R92:9cfbbf34f170: [mailcommon] Port to QSortFilterProxyModel from deprecated….Nov 30 2019, 11:53 AM

mlaurent mentioned this in R199:034f0ee898c2: [AkonadiConsole] Port to QSortFilterProxyModel from deprecated….

mlaurent mentioned this in R44:7827088bf1ee: [kdepim-runtime] Port to QSortFilterProxyModel from deprecated….

Revision Contents
Changeset List

			Path	Packages
M			autotests/libs/proxymodelstest.cpp (13 lines)
M			src/core/models/entityorderproxymodel.h (6 lines)
M			src/core/models/entityorderproxymodel.cpp (24 lines)
M			src/core/models/entityrightsfiltermodel.h (9 lines)
M			src/core/models/entityrightsfiltermodel.cpp (9 lines)
M			src/core/models/favoritecollectionsmodel.cpp (2 lines)
M			src/core/models/recursivecollectionfilterproxymodel.h (8 lines)
M			src/core/models/recursivecollectionfilterproxymodel.cpp (4 lines)
M			src/core/models/trashfilterproxymodel.h (8 lines)
M			src/core/models/trashfilterproxymodel.cpp (4 lines)