The handle now uses ToolButtons to support the checkable background toggle
The new handle action enables and disables the background and switches it
to a shadow with the new effectivebackgroundhints
Details
Details
- Reviewers
- None
- Group Reviewers
Plasma - Commits
- R119:e473bdd3f9ad: handle action for custom shadow background hint
Tested with different applets
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- mart/effectiveBackgroundHints
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 19250 Build 19268: arc lint + arc unit
Comment Actions
Generally +1.
Will approve once I've got through the applet change
containments/desktop/package/contents/ui/ActionButton.qml | ||
---|---|---|
36 | I try and follow a rule to have a rule that all: Layout.* Should be in the code of whoever creates the component, not in the component itself. (i.e ConfigOverlay) it makes things more portable |