handle action for custom shadow background hint
ClosedPublic

Authored by mart on Nov 28 2019, 1:55 PM.

Details

Summary

The handle now uses ToolButtons to support the checkable background toggle
The new handle action enables and disables the background and switches it
to a shadow with the new effectivebackgroundhints

Test Plan

Tested with different applets

Diff Detail

Repository
R119 Plasma Desktop
Branch
mart/effectiveBackgroundHints
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19248
Build 19266: arc lint + arc unit
mart created this revision.Nov 28 2019, 1:55 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 28 2019, 1:55 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Nov 28 2019, 1:55 PM
mart updated this revision to Diff 70501.Nov 28 2019, 2:39 PM
  • add missing Actionbutton refactor

Generally +1.

Will approve once I've got through the applet change

containments/desktop/package/contents/ui/ActionButton.qml
54

I try and follow a rule to have a rule that all:

Layout.*
Anchors.*
width/x/y/height properties

Should be in the code of whoever creates the component, not in the component itself. (i.e ConfigOverlay) it makes things more portable

mart updated this revision to Diff 70505.Nov 28 2019, 4:14 PM
  • move Layout.fillWidth on top
mart updated this revision to Diff 70514.Nov 28 2019, 5:12 PM
  • adapt to api changes
This revision was not accepted when it landed; it landed in state Needs Review.Nov 29 2019, 9:48 AM
This revision was automatically updated to reflect the committed changes.