KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties
ClosedPublic
Actions

Authored by crossi on Nov 28 2019, 9:12 AM.

Details

Reviewers

ervin
bport
mart
davidedmundson

Group Reviewers

Plasma

Commits

R119:a3b97eaa91c6: KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties

Diff Detail

Repository

R119 Plasma Desktop

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 19240
Build 19258: arc lint + arc unit

crossi created this revision.Nov 28 2019, 9:12 AM

Restricted Application added a project: Plasma. · View Herald TranscriptNov 28 2019, 9:12 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

crossi requested review of this revision.Nov 28 2019, 9:12 AM

Harbormaster completed remote builds in B19240: Diff 70480.Nov 28 2019, 9:12 AM

typo

Harbormaster completed remote builds in B19241: Diff 70482.Nov 28 2019, 9:19 AM

crossi retitled this revision from KCM WorkspaceOptioins port to KConfigXT. Take into account immutable properties to KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties.Nov 28 2019, 9:19 AM

ervin accepted this revision.Nov 28 2019, 9:37 AM

This revision is now accepted and ready to land.Nov 28 2019, 9:37 AM

Closed by commit R119:a3b97eaa91c6: KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties (authored by crossi). · Explain WhyNov 29 2019, 12:10 PM

This revision was automatically updated to reflect the committed changes.

ngraham mentioned this in D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does.Nov 29 2019, 4:06 PM

Thanks so much for this, it made D25361 such a breeze!

crossi mentioned this in D25843: Restore notifier on AnimationDurationFactor that was lost during KConfig XT port.Dec 10 2019, 1:09 PM

crossi mentioned this in D25792: Add notifiers to workspace options kcfg.Dec 10 2019, 1:10 PM

crossi mentioned this in R119:6ea1971ed13c: Restore notifier on AnimationDurationFactor that was lost during KConfig XT port.Jan 6 2020, 11:04 AM

bam added a subscriber: bam.Dec 20 2020, 4:32 PM

bam added inline comments.

kcms/workspaceoptions/workspaceoptions_plasmasettings.kcfg
15	Could we share it with the consumer of this setting itself in P-W? Currently it uses legacy way to access it's setting and thus can become out of sync easily: https://invent.kde.org/plasma/plasma-workspace/-/blob/master/shell/osd.cpp#L161

bam added inline comments.Dec 22 2020, 9:55 PM

kcms/workspaceoptions/workspaceoptions_plasmasettings.kcfg
16	Also maybe worth to add: `<tooltip>Show a popup for status changes such as brightness or volume</tooltip>` At least it was in original patch.

Revision Contents
Changeset List

		Path
M		kcms/workspaceoptions/CMakeLists.txt (5 lines)
M		kcms/workspaceoptions/package/contents/ui/main.qml (48 lines)
M		kcms/workspaceoptions/workspaceoptions.h (61 lines)
M		kcms/workspaceoptions/workspaceoptions.cpp (209 lines)
A	M	kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfg (17 lines)
A	M	kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfgc (6 lines)
A	M	kcms/workspaceoptions/workspaceoptions_plasmasettings.kcfg (19 lines)
A	M	kcms/workspaceoptions/workspaceoptions_plasmasettings.kcfgc (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	70480	9a69e40		Nov 28 2019, 9:12 AM	★	★
Diff 2	70482	9a69e40	typo	Nov 28 2019, 9:18 AM	★	★
Diff 3	70561	2b2383c	R119:a3b97eaa91c6b4015b15f5015229b46a273fb81b	Nov 29 2019, 12:05 PM	★	★