[TabBar] Use window color instead of button color
ClosedPublic

Authored by filipf on Nov 27 2019, 11:23 PM.

Details

Summary

If some color scheme (not Breeze) doesn't use the same button and window colors the tab sticks out.

BUG: 413311
FIXED-IN: 5.65

Test Plan

Before:


After:

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Branch
right-color (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19233
Build 19251: arc lint + arc unit
filipf created this revision.Nov 27 2019, 11:23 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 27 2019, 11:23 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Nov 27 2019, 11:23 PM
filipf edited the test plan for this revision. (Show Details)Nov 27 2019, 11:23 PM
filipf added reviewers: Plasma, VDG.
ngraham accepted this revision.Nov 27 2019, 11:34 PM
This revision is now accepted and ready to land.Nov 27 2019, 11:34 PM

Can you verify how the widgets QTabBar behaves in this scenario?

Can you verify how the widgets QTabBar behaves in this scenario?

It doesn't use the button color, but comparing the two reveals other dissimilarities:

Text color isn't the same, the frame actually has a color of its own in widgets, and the slider's handle color doesn't match either.

None of this is visible with Breeze so I guess that's why no one ever tweaked it.

In Breeze it uses the window color I think? See breezestyle.cpp#L5767 and the following lines

ngraham requested changes to this revision.Nov 29 2019, 5:20 PM

Yeah, the widget style version uses a lightened version of the window color for the active tab and the frame's background. Ideally we would do the same thing in the QQC2 desktop style. However this patch is enough to fix the bug in its current form so I think it can go in now, and we can investigate that in the next patch.

This revision now requires changes to proceed.Nov 29 2019, 5:20 PM
ngraham accepted this revision.Nov 29 2019, 5:20 PM

Oops.

This revision is now accepted and ready to land.Nov 29 2019, 5:20 PM
This revision was automatically updated to reflect the committed changes.