Fix build on windows
ClosedPublic

Authored by nicolasfella on Nov 27 2019, 5:21 PM.

Details

Summary

Otherwise build fails with

C:\CraftRoot\build\_\f41ea8b4\kpublictransport\src\datatypes\location.cpp(184): error C2015: Zu viele Zeichen in der Konstante
C:\CraftRoot\build\_\f41ea8b4\kpublictransport\src\datatypes\location.cpp(185): error C2015: Zu viele Zeichen in der Konstante
C:\CraftRoot\build\_\f41ea8b4\kpublictransport\src\datatypes\location.cpp(186): error C2015: Zu viele Zeichen in der Konstante
C:\CraftRoot\build\_\f41ea8b4\kpublictransport\src\datatypes\location.cpp(187): error C2015: Zu viele Zeichen in der Konstante
C:\CraftRoot\build\_\f41ea8b4\kpublictransport\src\datatypes\location.cpp(188): error C2015: Zu viele Zeichen in der Konstante

Diff Detail

Repository
R1032 KPublicTransport
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella requested review of this revision.Nov 27 2019, 5:21 PM
nicolasfella created this revision.
nicolasfella edited the summary of this revision. (Show Details)
vkrause accepted this revision.Nov 27 2019, 5:48 PM
This revision is now accepted and ready to land.Nov 27 2019, 5:48 PM
nicolasfella retitled this revision from Attempt to fix build on windows to Fix build on windows.Nov 27 2019, 5:52 PM
This revision was automatically updated to reflect the committed changes.

I guess it worked on windows because the compiler assumes utf8 source code? maybe there is a flag for android too?

On Linux it still builds but triggers compiler warnings and breaks a few unit tests.

Meh. I'll look into it within the next days. Feel free to revert until then