Differential D25569

Also overwrite document.createElement using exportFunction
ClosedPublic
Actions

Authored by broulik on Nov 27 2019, 4:21 PM.

Details

Reviewers
fvogt
davidedmundson
ognarb
Commits
R856:c2fba76125f4: Also overwrite document.createElement using exportFunction
Summary

Ensures it works in Firefox on sites with content security policy like Spotify.

Test Plan
  • Spotify works now in Firefox
  • Google Translate still works in Firefox

Needs more testing:

  • Firefox ESR
  • Chrome
  • the stuff that broke by replacing document.createElement before I changed it to use the Document.prototype

...

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Nov 27 2019, 4:21 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 27 2019, 4:21 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Nov 27 2019, 4:21 PM
fvogt accepted this revision.Nov 29 2019, 1:37 PM

Ugly...

This revision is now accepted and ready to land.Nov 29 2019, 1:37 PM
Closed by commit R856:c2fba76125f4: Also overwrite document.createElement using exportFunction (authored by broulik). · Explain WhyApr 9 2020, 3:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mextension/content-script.js (43 lines)

Diff 70439

View Options

extension/content-script.js

Loading...