Instead of using Qt::ScreenOrientation use an enum class that is directly
mapped to KWayland's transformation enums. This simplifies the code.
Details
Details
- Reviewers
zzag - Group Reviewers
KWin - Maniphest Tasks
- T11670: Improve Wayland output rotation
- Commits
- R108:e827d0a8ee98: Use Transform enum internally
Compiles and transformations work as before.
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| abstract_wayland_output.cpp | ||
|---|---|---|
| 154 | Make these two helpers static. | |
| abstract_wayland_output.cpp | ||
|---|---|---|
| 154 | Forgot to add it. Does it really make a difference in C++ though? To my knowledge it doesn't. | |
| abstract_wayland_output.cpp | ||
|---|---|---|
| 154 | Yes, it does make a difference. Using static will result in symbols local to the translation unit. Using inline will result in weak symbols. The second thing is that inline just gives a hint to inline the function. The compiler may ignore that hint, but it can also inline functions that are not marked with the inline keyword. So, making functions inline in this case is kind of pointless. | |