Remove KCompletion dependency
ClosedPublic

Authored by cordlandwehr on Nov 26 2019, 6:52 PM.

Details

Summary

For all uses of KLineEdit it is enough to use QLineEdit.

Test Plan

starts and works as expected

Diff Detail

Repository
R333 KLettres
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cordlandwehr created this revision.Nov 26 2019, 6:52 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptNov 26 2019, 6:52 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
cordlandwehr requested review of this revision.Nov 26 2019, 6:52 PM
aacid added a subscriber: aacid.Nov 26 2019, 9:25 PM

does this matter at all?

We're still using KNewStuff that uses KCompletion anyway

The rationale about this change is not the dependency but that we discovered a big number of unneeded uses of KLineEdit all over the KDE codebase at the KF6 Sprint. This makes it quite hard to evaluate which KLineEdit features are still relevant. Thus, the goal is to slowly start with removing unneeded KLineEdit usage.

aacid accepted this revision.Nov 27 2019, 9:04 PM

fair enough :)

This revision is now accepted and ready to land.Nov 27 2019, 9:04 PM
This revision was automatically updated to reflect the committed changes.