Differential D25549

[kcms/keyboard] Port away from KToolInvokation
ClosedPublic
Actions

Authored by nicolasfella on Nov 26 2019, 5:28 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Maniphest Tasks
T12185: KService: deprecate/slim down KToolInvocation
Commits
R119:13358835296e: [kcms/keyboard] Port away from KToolInvokation
Summary

kdeinit will most likely be dropped. Use QProcess to start it normally

Test Plan

Open KCM from SNI

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Nov 26 2019, 5:28 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 26 2019, 5:28 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Nov 26 2019, 5:28 PM
davidedmundson requested changes to this revision.Nov 26 2019, 5:38 PM
davidedmundson added a subscriber: davidedmundson.

I would prefer

KRun::somethingsomething

there's a lot of other magic when spawning a new process with environment variables for focus transfer that we don't want to accidentally lose

This revision now requires changes to proceed.Nov 26 2019, 5:38 PM
davidedmundson accepted this revision.Apr 2 2020, 11:19 AM

Changed my mind.

This is a kcm, so having a startup notification for kcm wouldn't bring a lot.
Also you're not going to have a different env between kcmshell5 and kcmshell5

This revision is now accepted and ready to land.Apr 2 2020, 11:19 AM
Closed by commit R119:13358835296e: [kcms/keyboard] Port away from KToolInvokation (authored by nicolasfella). · Explain WhyApr 2 2020, 2:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 79139

View Options

kcms/keyboard/CMakeLists.txt

Loading...
View Options

kcms/keyboard/layouts_menu.cpp

Loading...