Add default value for cursor theme
ClosedPublic

Authored by broulik on Nov 26 2019, 7:54 AM.

Details

Summary

When using the default cursors, no cursorTheme entry is written into the config file, leading to it resetting GTK to use "Adwaita" cursors.

BUG: 414109

Test Plan

Logged in and noticed my GTK cursor looked odd.
Compiled.
Haven't tested it yet as I need to log out but I'm sure it works :)

Diff Detail

Repository
R99 KDE Gtk Configuration Tool
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Nov 26 2019, 7:54 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 26 2019, 7:54 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Nov 26 2019, 7:54 AM

Hmm, somehow still doesn't apply the cursors on login

Did I understand correctly, that in order to test this I need to:

  1. Apply not a default cursor theme (for example Breeze_Snow)
  2. Comment a cursorTheme=Breeze_Snow line in ~/.config/kcminput
  3. Check that Gtk apps still using Breeze_Snow
  4. Log out and then log in again
  5. Check that Gtk apps are using breeze_cursors - the default cursors

?

Yes, when setting "Breeze" (not snow) as cursor theme, it will delete the key from the kcminputrc because it is the default.

This comment was removed by gikari.
ngraham accepted this revision.Nov 26 2019, 4:12 PM
This revision is now accepted and ready to land.Nov 26 2019, 4:12 PM
gikari accepted this revision.Nov 26 2019, 5:57 PM

It changes config correctly now (instead of empty cursor theme name, that was before), but somehow cursor does not change until I manually change the cursor theme in Cursors KCM.
Very strange.

ngraham edited the summary of this revision. (Show Details)Nov 27 2019, 2:31 PM
This revision was automatically updated to reflect the committed changes.