kontact: simplify ksycoca-related startup code
ClosedPublic
Actions

Authored by dfaure on Nov 25 2019, 6:45 PM.

Details

Reviewers

Commits

Summary

ksycoca is rebuilt in process these days, looping and waiting
[for kbuildsycoca] makes no sense anymore [for a long time now].

CCBUG: 414137

Test Plan

deleted ksycoca file, started kontact, it said "rebuilding ksycoca"
and started up fine

Repository

R209 Kontact

Branch

release/19.12

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19157
Build 19175: arc lint + arc unit

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

dfaure requested review of this revision.Nov 25 2019, 6:45 PM

This revision is now accepted and ready to land.Nov 25 2019, 6:55 PM

src/mainwindow.cpp
142	qCDebug(...) ?

src/mainwindow.cpp
142	It's a rare case, which I think should actually print the debug line in debugging mode. Not much point in categorized logging for a single and rare startup debug message.

			Path	Packages
M			src/mainwindow.h (1 line)
M			src/mainwindow.cpp (33 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	70311	457cd47		Nov 25 2019, 6:45 PM	★	★