KCM launch feedback : take into account immutable properties
ClosedPublic

Authored by crossi on Nov 25 2019, 3:30 PM.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 19147
Build 19165: arc lint + arc unit
crossi created this revision.Nov 25 2019, 3:30 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 25 2019, 3:30 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
crossi requested review of this revision.Nov 25 2019, 3:30 PM
crossi updated this revision to Diff 70300.Nov 25 2019, 3:33 PM

blank line

broulik added inline comments.
kcms/launch/package/contents/ui/main.qml
45

Imho this is confusing.
The property should be readonly property bool cursorImmutable: kcm.setings.immutable && .. and then this would be enabled: !immutable

crossi updated this revision to Diff 70304.EditedNov 25 2019, 4:21 PM

Make the property readonly, boolean condition to repeat the same pattern enabled: !immutable

crossi added inline comments.Nov 25 2019, 4:26 PM
kcms/launch/package/contents/ui/main.qml
45

Thanks for pointing this.

Reworked the property to make enabled assignement like the other.

ervin accepted this revision.Nov 26 2019, 10:45 AM

Indeed much better with Kai's suggestion.

This revision is now accepted and ready to land.Nov 26 2019, 10:45 AM
This revision was automatically updated to reflect the committed changes.