Differential D25525

KCM Style : take into account immutable properties
ClosedPublic
Actions

Authored by crossi on Nov 25 2019, 3:26 PM.

Details

Reviewers
ervin
bport
mart
davidedmundson
Group Reviewers
Plasma
Commits
R119:a7089ca61db2: KCM Style : take into account immutable properties
Summary

Update qqc2-desktop-style

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
crossi created this revision.Nov 25 2019, 3:26 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 25 2019, 3:26 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
crossi requested review of this revision.Nov 25 2019, 3:26 PM
ervin accepted this revision.Nov 26 2019, 10:36 AM

LGTM, assuming the patch to GridViewKCM goes in as is, if it's changed of course it'll need an adjustment here.

This revision is now accepted and ready to land.Nov 26 2019, 10:36 AM
crossi updated this revision to Diff 70351.Nov 26 2019, 2:43 PM

adjustment since view.enabled also show disabled look and feel

crossi edited the summary of this revision. (Show Details)Nov 26 2019, 2:45 PM
Closed by commit R119:a7089ca61db2: KCM Style : take into account immutable properties (authored by crossi). · Explain WhyNov 29 2019, 12:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 70559

View Options

kcms/style/package/contents/ui/EffectSettingsPopup.qml

Loading...
View Options

kcms/style/package/contents/ui/main.qml

Loading...