openSUSE requested that we just directly delete a theme based on its file path, instead of first checking if the theme exists in the sddm/themes directory.
CCBUG: 414289
FIXED-IN: 5.18
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma
Tried deleting a theme.
It still got deleted.
Diff Detail
Diff Detail
- Repository
- R123 SDDM Configuration Panel (KCM)
- Branch
- simpler-uninstall (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 19132 Build 19150: arc lint + arc unit
Comment Actions
I read the bug the other way round: instead of passing a full path (which would allow arbitrarily deleting folders as root?), pass a theme name and then do the lookup in the helper
Comment Actions
As far as I can tell theme names don't always match the names of folders they reside in.
I'm guessing I have to dig up the actually path value that gets set when creating the theme folder and then construct the file path here in the helper?
Comment Actions
We have code here that validates the path, so there must be a pattern.
We just need to instead of validating the path, construct it on the helper side.