Simpler theme deletion
Needs RevisionPublic

Authored by filipf on Nov 25 2019, 8:24 AM.


Group Reviewers

openSUSE requested that we just directly delete a theme based on its file path, instead of first checking if the theme exists in the sddm/themes directory.

CCBUG: 414289
FIXED-IN: 5.18

Test Plan

Tried deleting a theme.
It still got deleted.

Diff Detail

R123 SDDM Configuration Panel (KCM)
simpler-uninstall (branched from master)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 19132
Build 19150: arc lint + arc unit
filipf created this revision.Nov 25 2019, 8:24 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 25 2019, 8:24 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Nov 25 2019, 8:24 AM
filipf edited the test plan for this revision. (Show Details)Nov 25 2019, 8:25 AM
filipf added reviewers: davidedmundson, Plasma.

I read the bug the other way round: instead of passing a full path (which would allow arbitrarily deleting folders as root?), pass a theme name and then do the lookup in the helper

davidedmundson requested changes to this revision.Nov 25 2019, 8:40 AM

I also interpret it as such.

This revision now requires changes to proceed.Nov 25 2019, 8:40 AM
filipf added a comment.EditedNov 25 2019, 4:30 PM

As far as I can tell theme names don't always match the names of folders they reside in.

I'm guessing I have to dig up the actually path value that gets set when creating the theme folder and then construct the file path here in the helper?

We have code here that validates the path, so there must be a pattern.

We just need to instead of validating the path, construct it on the helper side.