Drop unused broken KGesture support
ClosedPublic

Authored by davidedmundson on Nov 24 2019, 7:27 PM.

Details

Summary

The functionality was disabled before kdelibs 3.5!
(7a390751076bafafc67557007172028956966ef1)

These classes were compile time skipped from KShortcutsEditor and
KShortcutsEditorItem and unused elsewhere in the library.

Gestures exist in some form in Qt.

The header files were installed as _p.h

The symbols were exported, but anyone using them was using clearly
private API.

Test Plan

Compiles

Diff Detail

Repository
R263 KXmlGui
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Nov 24 2019, 7:27 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 24 2019, 7:27 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Nov 24 2019, 7:27 PM
davidedmundson edited the summary of this revision. (Show Details)Nov 24 2019, 7:30 PM

Seems used in KAction in kdelibs4support.

apol added a subscriber: apol.Nov 25 2019, 3:51 PM

Seems used in KAction in kdelibs4support.

how does it make a difference? it's already commented.

It might break kdelibs4support compiling, I'll fix it out.

Right, kdelibs4support seems to include the deleted private headers, and uses these types in public API in KAction.

apol added a comment.Nov 25 2019, 4:07 PM

Right, kdelibs4support seems to include the deleted private headers, and uses these types in public API in KAction.

🤦

kdelibs4support usage has now been destroyed

vkrause accepted this revision.Dec 2 2019, 9:39 AM
This revision is now accepted and ready to land.Dec 2 2019, 9:39 AM
This revision was automatically updated to reflect the committed changes.
kossebau added inline comments.
src/CMakeLists.txt
147–148

You only wanted to stop installing those private headers, not all ;)
Fixed with 89670ad5e9d51390bcff340745f7ce7be4ddb322